Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NGINX overview dashboard #14660

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix NGINX overview dashboard #14660

merged 2 commits into from
Jun 1, 2023

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented May 31, 2023 •
edited
Loading

What does this PR do?

This PR updates the NGINX overview dashboard to remove nginx_log_count_by_status, since this is not a metric currently collected in the check.

Old:
image

New:
image

Motivation

Customer request

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 requested review from a team as code owners May 31, 2023 21:00
@ghost ghost added the integration/nginx label May 31, 2023
@yzhan289 yzhan289 merged commit 23052d6 into master Jun 1, 2023
@yzhan289 yzhan289 deleted the az/fix-nginx-overview branch June 1, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

@urseberry urseberry urseberry approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzhan289 @steveny91 @urseberry